fix: use accent color for text selection highlight#74
Conversation
Previously there was no custom selection style, making text selection hard to see in the dark theme. Now uses the user's accent color at 60% opacity so selections are visible and theme-aware. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94d4b16d99
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ::selection { | ||
| background: color-mix(in srgb, var(--color-brand) 60%, transparent); | ||
| color: #ffffff; |
There was a problem hiding this comment.
Avoid forcing white selection text
Setting ::selection text color to #ffffff makes selected text hard to read in light theme because the new background is a semi-transparent accent (color-mix(..., transparent)), which becomes a light tint over white surfaces (including default blue accent). This applies globally, so selecting text in inputs/chat can lose contrast; use a contrast-aware foreground (or leave text color unset) instead of hardcoded white.
Useful? React with 👍 / 👎.
|
This seems to not be an issue anymore. Closing. |
Summary
::selectionrule that uses the user's accent color (--color-brand) at 60% opacity for text selection backgroundTest plan
🤖 Generated with Claude Code