WIP: Add dashboard E2E coverage

[edgars-avotins]

What changed

Adds Proto Fleet dashboard E2E coverage for the paired-fleet shell and duration persistence after refresh.

Validation

• npx eslint e2eTests/protoFleet/pages/home.ts e2eTests/protoFleet/spec/dashboard.spec.ts
• npx playwright test spec/dashboard.spec.ts --project=desktop --no-deps
• npx playwright test spec/dashboard.spec.ts --project=mobile --no-deps

[github-actions]

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

• Reviewed pull request diff only (96e75576a55504d204b9fd58eb80f12e772156c8...6994398caf80eb821da2a6d1763d9d1fa671cc94, exact PR three-dot diff)
• Model: gpt-5.4

💡 Click "edited" above to see previous reviews for this PR.

---

Review Summary

Overall Risk: LOW

Findings

[LOW] Dashboard reload/navigation tests can pass while the panels are still only showing loading shells

• Category: Reliability
• Location: client/e2eTests/protoFleet/pages/home.ts:71
• Description: validateDashboardPanelVisible() only checks for the panel heading. That is too weak for the new refresh and navigation cases, because the dashboard panels keep their headings visible even when telemetry is still loading or the panel is in a fallback state. In other words, the new spec can report success without proving that the dashboard actually recovered after the duration change, page reload, or route round-trip.
• Impact: Regressions in telemetry refresh/persistence can slip through CI as false positives, which reduces the value of the new dashboard coverage.
• Recommendation: After changing duration, refreshing, or navigating back, wait for a non-loading marker tied to real content, such as skeleton disappearance, chart readiness, or a stable metric/status value.

[LOW] Duration persistence assertions are coupled to Tailwind classes instead of selected-state semantics

• Category: Reliability
• Location: client/e2eTests/protoFleet/pages/home.ts:83
• Description: validateDurationSelected() and getSelectedDuration() infer selection from bg-core-primary-fill. That makes the new tests depend on the current visual implementation rather than the actual selected state.
• Impact: Unrelated styling/token refactors can break CI, and the tests become noisier than the behavior they are meant to protect.
• Recommendation: Expose semantic selected state on the duration buttons, such as aria-pressed, data-selected, or a dedicated test id, and assert on that instead of CSS classes.

Notes

• .git/codex-review.diff only touches Playwright test code under client/e2eTests/protoFleet/; I did not find production auth, SQL, gRPC, plugin, frontend runtime, or infrastructure changes in scope for this review.

---

_{Generated by Codex Security Review |
Triggered by: @edgars-avotins |
Review workflow run}