Closed
Conversation
Remove the auto-detected light/dark promise from Appearance and treat the saved theme as the source of truth during startup so the shell comes up with the selected palette instead of a system-driven fallback. Keep user-selected accent colors layered on top of the chosen theme and cover both theme persistence and accent persistence in the Playwright settings flow.
tellaho
changed the title
tellaho
changed the title
Collaborator
Author
|
Closing, I was running into theme-switching not working. But it looks like I just needed to rebuild and get the latest from main? ¯_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Desktop users now choose a theme directly, and Sprout keeps using that theme until they pick a different one.
Problem: The Appearance settings copy implied that Sprout would auto-detect light and dark mode, but the desktop app was really persisting a concrete theme selection. That made the theme picker feel misleading even when it was mostly working.
Solution: Update the desktop theme flow so the saved theme is treated as the explicit source of truth from startup, rewrite the Appearance copy to match that behavior, and keep the existing user accent override intact.
File changes
desktop/src/features/settings/ui/SettingsPanels.tsx
Rewords Appearance so it describes an explicit theme choice instead of system-driven mode switching. Keeps the theme selector and accent swatches behaving the way users already expect.
desktop/src/main.tsx
Removes the redundant default theme prop now that the provider owns the default selection internally.
desktop/src/shared/theme/ThemeProvider.tsx
Makes the saved theme the startup source of truth, keeps cached theme vars versioned, and reapplies the saved accent after theme changes. This is the core behavior change that makes the picker mean “this is your theme” while preserving accent customization.
desktop/src/shared/theme/theme-loader.ts
Cleans up theme metadata extraction helpers used by the provider during theme application.
desktop/tests/e2e/profile.spec.ts
Updates the settings Playwright coverage to assert the real contract: theme selection persists, and a user-picked accent survives later theme changes.
Cmd+,on macOS orCtrl+,on other platforms.GitHub Lightand confirm the app switches to that theme.Draculaand confirm the theme changes while the chosen accent stays in place.