Skip to content

Fix wt-metadata-refresh failing on .bazelproject with commented directories #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guodong-sq merged 1 commit into from
Apr 15, 2026
Merged

Fix wt-metadata-refresh failing on .bazelproject with commented directories #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions lib/wt-metadata-refresh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ parse_bazelproject_directories() {
awk '
/^directories:/ { in_dirs=1; next }
/^[a-z_]+:/ { in_dirs=0 }
in_dirs && /^[[:space:]]+[^#]/ { gsub(/^[[:space:]]+/, ""); print }
in_dirs { gsub(/^[[:space:]]+/, ""); if ($0 != "" && !/^#/) print }
' "$bazelproject_file"
}

Expand Down Expand Up @@ -281,17 +281,10 @@ refresh_targets_file() {
# Run bazel query from the MAIN REPO ROOT (not project root)
# This is important because .bazelproject directories are relative to repo root
local query_output
local query_exit_code=0

query_output=$(
cd "$WT_MAIN_REPO_ROOT" 2>/dev/null && \
bazel query "$full_query" --output=label 2>/dev/null | sort
) || query_exit_code=$?

if [[ $query_exit_code -ne 0 ]]; then
warn " Bazel query failed for $project_name (exit code: $query_exit_code)"
return 1
fi
{ bazel query "$full_query" --output=label --keep_going 2>/dev/null || true; } | sort
)

if [[ -z "$query_output" ]]; then
warn " Bazel query returned empty results for $project_name"
Expand Down