Conversation
ch4r10t33r
left a comment
There was a problem hiding this comment.
This looks good. Should we also include a test for this? I am surprised this compilation error wasn't caught before. Also please can you bump the version?
should we add tests to this PR itself or should I make a separate one for that? |
I would prefer you adding tests to this PR itself. But yes, I agree we can release a new version once you are satisfied after testing. |
|
@ch4r10t33r can we get this merged first? Will raise the test PR separately. This way we all have these changes and I can even get the ssz integration PR out |
|
Sounds good to me. |
Fixes compilation errors discovered during ssz.zig integration:
assert()call (std.debug.assert only accepts boolean)fromMontgomery()withtoNormal()method