You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tests for the changes have been added (for bug fixes / features) -> not necessary as it is only a func exposure
Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
I exposed the ws creation function so that recreating the connection is possible in a module-friendly way. As Nest.JS doesn't support runtime recreation of whole modules this is the only way to instantiate WS connection like the guys asked in Reconnect when connect closed #5 . We ran in the same issue, thus the fix. If this method is exposed we can use it on-demand(like onClose just recreate it).
Could you make it platform-agnostic please? ('build' fails due to the 'rm" command). Thank u so much!
@JorgeMorata you can set git bash as default shell for running npm scripts. This will fix the issue with the rm command. Just make sure to enter the right path to your git bash (the one from the linked answer was not suitable for my installation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
I exposed the ws creation function so that recreating the connection is possible in a module-friendly way. As Nest.JS doesn't support runtime recreation of whole modules this is the only way to instantiate WS connection like the guys asked in Reconnect when connect closed #5 . We ran in the same issue, thus the fix. If this method is exposed we can use it on-demand(like
onClosejust recreate it).What is the current behavior?
Issue Number: #5 .
What is the new behavior?
Does this PR introduce a breaking change?
Other information