Skip to content

Nalee Riddell --- Components-BEM#75

Open
odax wants to merge 3 commits intobloominstituteoftechnology:masterfrom
odax:master
Open

Nalee Riddell --- Components-BEM#75
odax wants to merge 3 commits intobloominstituteoftechnology:masterfrom
odax:master

Conversation

@odax
Copy link
Copy Markdown

@odax odax commented Mar 28, 2018

No description provided.

@justinborek
Copy link
Copy Markdown

What Went Well:

Nice start on this one! Other than the error with the dropdown everything looks good, and your code looks good as well. Nice use of the BEM conventions as well. Your commit messages are good as well.

Areas For Improvement:

I figured out the error you were having. For your script declaration you were using:

<script type="text/javascript" src="script.js"></script>

I was able to get it working by changing it to:

<script defer="defer" src="script.js"></script>

The defer tag tells Javascript to wait until the page parses to run the scripts. What was happening under the hood was that your Javascript was trying to run when the classes hadn't actually been declared so it couldn't find the variables. There you go! Changing that one line makes the whole thing work.

Questions:

None.

Rating (1-3): 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants