Skip to content

Morales.ComponentsBEMSOLO#83

Closed
ghost wants to merge 3 commits intomasterfrom
unknown repository
Closed

Morales.ComponentsBEMSOLO#83
ghost wants to merge 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 28, 2018

This is my solo project after finishing a group PR with Michal and Iqra.

Group PR: #92

WIP

Copy link
Copy Markdown

@frogr frogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey David.

I understand that you're going to be out today and you're probably entirely preoccupied. Sorry again.

I do still have to review this code, however. It looks like you did not complete this on your own as there's no dropdown and all the styling on the page seems goofed up.

It looks like in the group project, however, this was completed to spec. I'm wondering if you just took this solo opportunity to mess around and figure out what was going on? Or if there was a separate issue.

If you can, let me know when you're free. Again, I totally understand if you're preoccupied with what's going on in real life today, and don't worry about getting back to me urgently, take all the time that you need.

Thanks for the submission!

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 1, 2018

Yes, I was working on this solo without an intent to finish it as we worked collectively on the group PR. I was messing around with some things so it was not finished.

@ghost ghost closed this by deleting the head repository Sep 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant