Jaivon Massena#85
Open
jaivonmassena wants to merge 4 commits intobloominstituteoftechnology:masterfrom
Open
Conversation
What Went Well:Nice work on this one. All the functions work as they're supposed to, and it looks like the supplied markup. Your code looks good as well, and nice use of the BEM naming conventions. Great commit messages as well! Keep it up!Areas For Improvement:Although the code works, try to refactor using the ES6 class syntax. Also, in your dropdown section you use
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.