Justin Ruiz PR#149
Justin Ruiz PR#149w0rmw00d94 wants to merge 1 commit intobloominstituteoftechnology:masterfrom w0rmw00d94:master
Conversation
|
Justin, Some suggestions for your coding: when you place comments at the end of the line, the comments stretch way beyond what is comfortable viewing. It is better to use quotes above and below your code, as in most editors those comments would just be wrapped and then would be hard to read, or else would go off the edge of an editor, again making them hard to read. I understand you put them there to explain to yourself what the code is doing, but its just better to get into the habit of making your code look good professionally at this point. Try converting traditional for-loops (let i = 0; i < ..; i++) into functional loops (forEach, filter, reduce, etc.) (for example, in tree at lines 21-25). binary-search-tree looks really good (with the same caveat about the long comment lines). Wesley |
finished tree and bst, but didn't get very far on graph. was a little confused