Conversation
Reviewer's Guide by SourceryThis pull request modifies the rocker configuration file (rockerc.yaml) by removing 'lazygit' and adding 'cwd' to the list of arguments. Updated class diagram for rocker configurationclassDiagram
class RockerConfig {
-args: list
}
note for RockerConfig "'lazygit' removed from args, 'cwd' added"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @blooop - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's unclear what the
cwdargument is used for - please add a description to the commit message.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request updates the rocker configuration file to remove
lazygitand addcwdto the list of arguments passed to the rocker CLI tool.Enhancements:
cwdto the list of arguments passed to the rocker CLI tool.Chores:
lazygitfrom the list of arguments passed to the rocker CLI tool.