fix(runtime): guard optional chrome and add 100dvh viewport fallback#1
Open
Reebz wants to merge 1 commit into
Open
fix(runtime): guard optional chrome and add 100dvh viewport fallback#1Reebz wants to merge 1 commit into
Reebz wants to merge 1 commit into
Conversation
A missing decorative element killed the whole deck: the particle, nav-dot, and progress code dereferenced optional nodes in global scope, so one absent element threw before any handler attached. Guard each optional node, matching the inline template runtime that already guards them. Separately, the Pro deck height keyed off 100vh, so the bottom slide line clipped under mobile browser chrome; add a 100dvh fallback that degrades to 100vh where dvh is unsupported. Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) <noreply@anthropic.com>
|
@Reebz is attempting to deploy a commit to the bluedusk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two high-severity fixes found by building and deploying a real 16:9 deck with the skill.
Null-guard the Pro runtime.
assets/slides-runtime.jsruns top to bottom in global scope and dereferences#particles, the nav-dot rail,#progress, and#counterwith no guard. A deck that omits any of these decorative elements throws before a single handler attaches, so the whole deck goes non-interactive. The inline template runtime inreferences/html-template.mdalready guards these, and this brings the Pro runtime to parity.100dvhfallback.assets/components.cssdrives.deckheight from100vh, so the bottom slide line clips under the iOS URL bar and home indicator. Declaringheight: 100vhthenheight: 100dvhkeeps the old value wheredvhis unsupported and uses the dynamic viewport on modern mobile. The100vhinside thefloatPkeyframes is an animation transform and is left untouched.Test
testing/fixtures/deck-no-particles.html(added) omits#particles,#progress, and#counterand stays fully navigable by keyboard, dots, wheel, and touch. Before the fix this deck is dead.Notes
This is the smallest and highest-value change in a set of eight independent PRs opened against this fork. The other seven build on this runtime and viewport baseline, so merging this one first is the cleanest order.
Co-Authored-By: Leslie Barbara Knope (Claude Opus 4.8 (1M context)) noreply@anthropic.com