Skip to content

Make search button a toggle#2053

Draft
infirit wants to merge 5 commits intoblueman-project:mainfrom
infirit:searchbuttonstop
Draft

Make search button a toggle#2053
infirit wants to merge 5 commits intoblueman-project:mainfrom
infirit:searchbuttonstop

Conversation

@infirit
Copy link
Contributor

@infirit infirit commented Mar 26, 2023

Still need to clean it up and drop the stop from the progressbar but putting it here for some feedback.
edit: updated screenhot and hid the cancel button

image

@cschramm
Copy link
Member

cschramm commented Apr 2, 2023

I like it. 👍 Brings us a little closer to also drop the timeout mechanism, but it would need some animation other than the progress bar, I guess. That stop icon's border looks like it could be spinning. 😅

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@infirit
Copy link
Contributor Author

infirit commented Apr 15, 2023

How about a spinner like this.
spinner.webm

@github-actions github-actions bot added the stale label Feb 22, 2024
@github-actions github-actions bot closed this Mar 1, 2024
@cschramm cschramm removed the stale label Mar 1, 2024
@cschramm cschramm reopened this Mar 1, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants