Open
Conversation
register_object_with_closures is deprecated in favor of register_object_with_closures2, since the original leaks memory or otherwise requires some extra work to avoid leaking memory, I don't fully understand: > Deprecated in favour of g_dbus_connection_register_object_with_closures2(), which has more binding-friendly reference counting semantics. Keep getattr fallback so older GLib runtimes still work.
|
Contributor
|
There is more information in the commit that introduced version 2. Preferably id like pygobject to add an override for this so it just works transparently for all projects. But I think having this in blueman is OK as it's simple enough. Ill post some links to relevant discussion later. Commit adding v2 with context: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4431 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_object_with_closuresis deprecated in favor ofregister_object_with_closures2, since the original leaks memory or otherwise requires some extra work to avoid leaking memory, I don't fully understand:Keep getattr fallback so older GLib runtimes still work.
Fixes #3101
Testing:
I've been running this patch locally for 8 days with no issues. I've also got this minimal reproducer, which quickly shows the fix works: