frontend: Fix background color of extensions page log

[patrickelectric]

Summary by Sourcery

Improve robustness and styling of the extension manager log display.

Bug Fixes:

• Prevent errors in extension log handling when the streaming response is missing.
• Adjust extension log text color to use the appropriate theme variable for better contrast with the background.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the extensions page log handling to safely process streaming responses and adjusts the log text color to use the sheet background token for better visual consistency with its background.

Class diagram for updated log handling in ExtensionManagerView

classDiagram
  class ExtensionManagerView {
    +handleLogProgress(progressEvent, extension)
  }

  class StreamProgressEvent {
    +currentTarget
  }

  class InstalledExtensionData

  class StreamingResponseUtils {
    +aggregateStreamingResponse(chunks, predicate)
    +parseStreamingResponse(response)
  }

  ExtensionManagerView --> StreamProgressEvent : uses
  ExtensionManagerView --> InstalledExtensionData : uses
  ExtensionManagerView ..> StreamingResponseUtils : uses

Loading

File-Level Changes

Change	Details	Files
Make log streaming handler resilient to missing response objects in progress events.	Store progressEvent.currentTarget.response in a local response variable using optional chaining. Add a null/undefined guard that returns early when response is not available. Pass the local response variable to parseStreamingResponse instead of accessing the property inline.	core/frontend/src/views/ExtensionManagerView.vue
Adjust the log text color to match the design tokens for sheet backgrounds.	Change pre.logs color from a semi-transparent on-surface color to var(--v-sheet_bg-base). Preserve existing background, padding, and overflow styles for the log block.	core/frontend/src/views/ExtensionManagerView.vue

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• When progressEvent?.currentTarget?.response is missing, the handler now silently returns; if this situation is unexpected, consider adding at least a debug log or error state so failures to stream logs are visible during troubleshooting.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When `progressEvent?.currentTarget?.response` is missing, the handler now silently returns; if this situation is unexpected, consider adding at least a debug log or error state so failures to stream logs are visible during troubleshooting.

## Individual Comments

### Comment 1
<location> `core/frontend/src/views/ExtensionManagerView.vue:1240` </location>
<code_context>

 pre.logs {
-  color: rgba(var(--v-theme-on-surface), 0.9);
+  color: var(--v-sheet_bg-base);
   background: var(--v-sheet_bg_complement-base);
   padding: 10px;
</code_context>

<issue_to_address>
**suggestion (bug_risk):** New `pre.logs` color token may reduce contrast against `background` for log text

Using `var(--v-sheet_bg-base)` ties the text color to a background token, which may not be tuned for foreground/readability, especially against `var(--v-sheet_bg_complement-base)` in some themes (notably dark mode). Consider using a dedicated text/foreground token instead (or keeping the `on-surface`-based color) to ensure sufficient contrast across themes.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): New pre.logs color token may reduce contrast against background for log text

Using var(--v-sheet_bg-base) ties the text color to a background token, which may not be tuned for foreground/readability, especially against var(--v-sheet_bg_complement-base) in some themes (notably dark mode). Consider using a dedicated text/foreground token instead (or keeping the on-surface-based color) to ensure sufficient contrast across themes.