Add error checks for all I2C reads and writes and return error values#26
Open
waynepiekarski wants to merge 2 commits intobluerobotics:masterfrom
Open
Add error checks for all I2C reads and writes and return error values#26waynepiekarski wants to merge 2 commits intobluerobotics:masterfrom
waynepiekarski wants to merge 2 commits intobluerobotics:masterfrom
Conversation
Author
|
@patrickelectric I was hoping you could review this code which fixes some bugs in the sensor error handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the device is not connected or if any of the I2C operations fail, the library will receive all zeros, continue with the calculations, and then return incorrect values. Previously it was not possible to return an error code from read() either, so this has been added as well.