Non-blocking drop-in replacement for read() function#28
Open
RedshiftVelocities wants to merge 7 commits intobluerobotics:masterfrom
Open
Non-blocking drop-in replacement for read() function#28RedshiftVelocities wants to merge 7 commits intobluerobotics:masterfrom
RedshiftVelocities wants to merge 7 commits intobluerobotics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read() function now no longer locks up the Arduino for 40ms. It can be run every main loop, but only communicates with the sensor within the timing spec in the datasheet. The example sketch has also been updated to demonstrate this. These changes are a drop-in replacement for the existing read() function.
Note that I haven't been able to test the code on a real sensor; I've just used another Arduino pretending to be one.