Omniscan3D updated to be more python friendly#226
Closed
steve-at-oblique wants to merge 1 commit into
Closed
Conversation
Member
|
Hi, please take a look in CI, it appears to be failing.
Patrick José Pereira
Electronics Engineer
…On Fri, Jun 5, 2026, 15:47 SteveJennen ***@***.***> wrote:
This change updates the OmniScan3D protocol definition to better support
Python code generation and runtime message handling.
Changes include:
- Reworked OmniScan3D message definitions to use dynamic payloads
compatible with the existing PingMessage variable-length message
infrastructure.
- Removed reliance on vector definitions that generated Python
structures which did not match the actual OmniScan3D packet formats.
- Updated message definitions to more accurately represent the wire
protocol for:
- os3d_set_ping_params
- attitude_report
- os3d_point_set
- end_ping_info
- Simplified generation of Python bindings by treating point data as
dynamic payload data rather than generated vector structures.
- Verified that the updated protocol definitions successfully generate
a functional omniscan3d.py implementation.
The goal of this change is to make OmniScan3D integration consistent with
the existing Python protocol implementation while reducing custom parsing
requirements and avoiding generation of incorrect helper structures.
------------------------------
You can view, comment on, or merge this pull request online at:
#226
Commit Summary
- ab36d59
<ab36d59>
Omniscan3d updated to be more python friendly
File Changes
(2 files <https://github.com/bluerobotics/ping-protocol/pull/226/files>)
- *M* src/definitions/omniscan3d.json
<https://github.com/bluerobotics/ping-protocol/pull/226/files#diff-3cdf06428ec9658bfb2343d37e36dbd217f0b9c91dfbf2de3a55eda93fb007c4>
(114)
- *M* src/generator.py
<https://github.com/bluerobotics/ping-protocol/pull/226/files#diff-622b7462e7c96eb3d7d183c8eeb435b9c195618dbc6ebbd17e9e004578d81b0e>
(2)
Patch Links:
- https://github.com/bluerobotics/ping-protocol/pull/226.patch
- https://github.com/bluerobotics/ping-protocol/pull/226.diff
—
Reply to this email directly, view it on GitHub
<#226?email_source=notifications&email_token=AAJIYCLRXT4ERQPBMLQ5AAD46MIU5A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTQMJSGEZTOOBRGCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6Y3MNFRWW>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJIYCNBMOUNXPPLZ4SIO6D46MIU5AVCNFSM6AAAAACZ4H2ZOWVHI2DSMVQWIX3LMV43ASLTON2WKOZUGU4TSMRZHEZDOMY>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAJIYCK7APGBERAE34O5GET46MIU5A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTQMJSGEZTOOBRGCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVJTG633UMVZF62LPOM>
and Android
<https://github.com/notifications/mobile/android/AAJIYCMEQ2Y5W44MUYYPHF346MIU5A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTQMJSGEZTOOBRGCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVZTG633UMVZF6YLOMRZG62LE>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the OmniScan3D protocol definition to better support Python code generation and runtime message handling.
Changes include:
The goal of this change is to make OmniScan3D integration consistent with the existing Python protocol implementation while reducing custom parsing requirements and avoiding generation of incorrect helper structures.