Open
Conversation
1. It wasn't public which seemed like a mistake. 2. It previously returned IEnumerator<KVPair<...>> which makes no sense. I upgraded it to IReadOnlyDictionary since there's no reason not to and this is more useful.
This file had no business containing all these random types.
This means that if the user passes in a single locale like `en-US` plural handling won't break. Also allows users to pass custom CultureInfo objects that can have custom formatting parameters (or, for example, disable user system overrides) Yes I did this because the tests failed on my system due to that last point.
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 93.61% 93.70% +0.09%
==========================================
Files 26 30 +4
Lines 1941 1890 -51
==========================================
- Hits 1817 1771 -46
+ Misses 124 119 -5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for this not being separate PRs, I initially wanted to fix more about the library and figured all the fixes would interconflict anyways so this would be saner. Then I realized the problem is that this library is built on an ancient pre-1.0 version of fluent.js that itself was a complete trash fire code wise so I kind of gave up midway fixing more.
Frankly this library would be better served being re-ported from the current TypeScript or Rust implementations since dear god this old JS implementation is awful but I don't really have the motivation to do such an undertaking, so...
This PR still contains some useful fixes/improvements though that I could use so I figured I'd still submit it.
The individual commits have the individual changes, so look at those.
Should be no backwards compatibility breakages (there is an
[Obsolete]now though).