Fix learning rate schedulers not correctly calculating the number of total training steps#7
Open
adsfssd wants to merge 1 commit intobluvoll:experimentalfrom
Open
Fix learning rate schedulers not correctly calculating the number of total training steps#7adsfssd wants to merge 1 commit intobluvoll:experimentalfrom
adsfssd wants to merge 1 commit intobluvoll:experimentalfrom
Conversation
adsfssd
force-pushed
the
lr_scheduler_fix
branch
from
a9b3912 to
d26317b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turns out in #5, lr scheduler initialization was not moved below
args.max_train_stepsrecalculation which caused a bug whereargs.max_train_stepspassed totrain_util.get_scheduler_fixwas incorrect