Skip to content

feat: issue 2243#2260

Open
muratkeremozcan wants to merge 3 commits intomainfrom
feat/issue-2243-bmad-side
Open

feat: issue 2243#2260
muratkeremozcan wants to merge 3 commits intomainfrom
feat/issue-2243-bmad-side

Conversation

@muratkeremozcan
Copy link
Copy Markdown
Contributor

@muratkeremozcan muratkeremozcan commented Apr 13, 2026

Addresses #2243.

What

Added ATDD-aware implementation handoff in Phase 4 so create-story surfaces /bmad:tea:atdd before dev-story, and dev-story can discover, load, and consume TEA-generated ATDD artifacts when they exist.

Why

This closes the integration gap where BMM Phase 4 ignored TEA acceptance-test scaffolds and gave no durable story-level pointer to those artifacts. Fixes #2243.

How

  • Updated create-story workflow output and story template to introduce an optional ATDD Artifacts section and recommend running /bmad:tea:atdd before dev-story.
  • Updated dev-story workflow to load ATDD references from Dev Notes, fall back to atdd-checklist-{story_key}.md discovery, and activate relevant test.skip() or legacy test.fixme() scaffolds before writing new failing tests.
  • Added Definition of Done checks so completed functionality cannot leave relevant ATDD scaffold markers blocked, and adjusted Phase 4 help descriptions to mention optional ATDD consumption.

Testing

Validated the changed workflow/template files with git diff --check and manually reviewed the updated Phase 4 flow for consistency from create-story through dev-story. No runtime test suite was run because these changes are workflow/catalog/template logic rather than executable application code.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

This PR integrates ATDD (Acceptance Test-Driven Development) artifact handling into the BMM story workflow. Changes span four documentation files: updating create-story template and workflow to include an optional ATDD step, and extending dev-story checklist and workflow to detect, load, and conditionally activate pre-generated ATDD scaffold tests during implementation.

Changes

Cohort / File(s) Summary
Create Story Integration
src/bmm-skills/4-implementation/bmad-create-story/template.md, src/bmm-skills/4-implementation/bmad-create-story/workflow.md
Added optional ATDD step placement in workflow after validation and before dev-story. Introduced "ATDD Artifacts (Optional)" section in template to capture TEA checklist references, generated test paths, and activation guidance.
Dev Story Consumption
src/bmm-skills/4-implementation/bmad-dev-story/checklist.md, src/bmm-skills/4-implementation/bmad-dev-story/workflow.md
Extended dev-story to load and reference ATDD artifacts from story Dev Notes, conditionally activate pre-generated scaffold tests by removing test.skip() during RED phase, and preserve/extend ATDD tests instead of duplicating acceptance coverage. Added validation rules and test checklist items for ATDD artifact handling.

Sequence Diagram(s)

sequenceDiagram
    participant StoryCreator as Story Creator
    participant Validator as Validate Step
    participant ATDD as TEA / ATDD<br/>(Optional)
    participant DevStory as Dev Story<br/>Workflow
    participant TestRunner as Test Runner
    participant DevAgent as Dev Agent<br/>Record

    StoryCreator->>StoryCreator: Create story with acceptance criteria
    StoryCreator->>Validator: Trigger validate-create-story
    Validator->>Validator: Review & validate story
    Validator-->>StoryCreator: Validation complete
    
    Note over ATDD,StoryCreator: Optional ATDD path (if TEA installed)
    StoryCreator->>ATDD: Trigger /bmad:tea:atdd
    ATDD->>ATDD: Generate scaffold tests<br/>(API, E2E, Component)
    ATDD->>StoryCreator: Link ATDD artifacts<br/>& checklist to Dev Notes
    
    StoryCreator->>DevStory: Trigger dev-story<br/>with ATDD artifacts (if available)
    DevStory->>DevAgent: Load ATDD checklist<br/>from Dev Notes references
    DevAgent-->>DevStory: Extract test inventory<br/>& activation guidance
    
    Note over DevStory,TestRunner: RED Phase - Conditional Test Activation
    alt ATDD Scaffold Tests Exist
        DevStory->>TestRunner: Activate scaffold tests<br/>(remove test.skip())
        TestRunner->>TestRunner: Run scaffold tests<br/>(expect failures)
        TestRunner-->>DevStory: Tests fail (RED phase)
    else No ATDD Artifacts
        DevStory->>TestRunner: Write new failing tests<br/>(original behavior)
        TestRunner-->>DevStory: Tests fail (RED phase)
    end
    
    DevStory->>DevStory: Implement feature<br/>(activate/extend ATDD tests)
    DevStory->>DevAgent: Update file list<br/>(include ATDD test files)
    DevStory->>TestRunner: Run tests
    TestRunner-->>DevStory: Tests pass (GREEN phase)
    DevStory-->>StoryCreator: Implementation complete
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • bmadcode
  • pbean
  • cecil-the-coder
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'feat: issue 2243' is vague and non-descriptive; it references an issue number without conveying what the actual change accomplishes. Provide a concise, descriptive title summarizing the main change, such as 'feat: integrate TEA ATDD workflow into story creation and development' instead of just the issue number.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description clearly relates to the changeset, detailing ATDD artifact integration in Phase 4, create-story workflow updates, and dev-story consumption logic across all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/issue-2243-bmad-side

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 13, 2026

🤖 Augment PR Summary

Summary: Integrates optional Test Architect (TEA) ATDD artifacts into the story creation and dev-story workflows.

Changes:

  • Extends the create-story template to include an optional ATDD Artifacts subsection in Dev Notes.
  • Updates create-story workflow “Next Steps” to optionally run /bmad:tea:atdd before dev-story, and clarifies that dev-story can consume ATDD artifacts.
  • Enhances dev-story workflow initialization to detect and load referenced ATDD artifacts/checklists from story Dev Notes.
  • Adjusts the dev-story RED phase to activate relevant scaffold tests (vs. always authoring new failing tests first) when ATDD artifacts exist.
  • Updates the dev-story Definition of Done checklist to account for consuming/activating TEA-generated scaffolds and avoiding duplicated acceptance coverage.
Technical Notes: This is primarily workflow/template guidance; it relies on consistent Dev Notes structure so ATDD outputs can be referenced and reused during implementation.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/bmm-skills/4-implementation/bmad-create-story/template.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TEA ATDD workflow has no integration points in BMM Phase 4 pipeline or bmad-help routing

1 participant