Skip to content

fix: rename setup-skill-template to avoid BMM scanner error #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmadcode wants to merge 1 commit into from
Closed

fix: rename setup-skill-template to avoid BMM scanner error #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...lder/assets/setup-skill-template/SKILL.md → ...der/assets/_setup-skill-template/SKILL.md
View file
Open in desktop
File renamed without changes.
0 ...tup-skill-template/assets/module-help.csv → ...tup-skill-template/assets/module-help.csv
View file
Open in desktop
File renamed without changes.
0 ...s/setup-skill-template/assets/module.yaml → .../_setup-skill-template/assets/module.yaml
View file
Open in desktop
File renamed without changes.
0 ...-skill-template/scripts/cleanup-legacy.py → ...-skill-template/scripts/cleanup-legacy.py
View file
Open in desktop
File renamed without changes.
0 ...up-skill-template/scripts/merge-config.py → ...up-skill-template/scripts/merge-config.py
View file
Open in desktop
File renamed without changes.
0 ...-skill-template/scripts/merge-help-csv.py → ...-skill-template/scripts/merge-help-csv.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion skills/bmad-module-builder/scripts/scaffold-setup-skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def main() -> int:
)
args = parser.parse_args()

template_dir = Path(__file__).resolve().parent.parent / "assets" / "setup-skill-template"
template_dir = Path(__file__).resolve().parent.parent / "assets" / "_setup-skill-template"
Copy link
Copy Markdown

@augmentcode augmentcode bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module docstring still says it "Copies the setup-skill-template" (near the top of this file), but the directory was renamed to _setup-skill-template. Consider updating the docstring to match so users/maintainers aren’t misled when diagnosing missing-template errors.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

setup_skill_name = f"{args.module_code}-setup"
target = Path(args.target_dir) / setup_skill_name

Expand Down
2 changes: 1 addition & 1 deletion skills/bmad-module-builder/scripts/tests/test-scaffold-setup-skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from pathlib import Path

SCRIPT = Path(__file__).resolve().parent.parent / "scaffold-setup-skill.py"
TEMPLATE_DIR = Path(__file__).resolve().parent.parent.parent / "assets" / "setup-skill-template"
TEMPLATE_DIR = Path(__file__).resolve().parent.parent.parent / "assets" / "_setup-skill-template"


def run_scaffold(tmp: Path, **kwargs) -> tuple[int, dict]:
Expand Down
Loading