fix(setup): run merge-config with uv#295
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe setup skill documentation now runs the dependency-bearing ChangesSetup script execution
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_setup_cleanup_scripts.py`:
- Around line 292-296: Update
test_setup_skill_uses_uv_for_dependency_bearing_merge_config to also assert that
“python3 ./scripts/merge-help-csv.py” appears exactly twice, while preserving
the existing uv invocation and exclusion assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: beddbde5-d917-4286-b371-744446c1e114
📒 Files selected for processing (2)
src/bmad_loop/data/skills/bmad-loop-setup/SKILL.mdtests/test_setup_cleanup_scripts.py
|
closed as duplicate of #297 and already resolved |
What
Run the dependency-bearing
merge-config.pysetup helper throughuv, including its documented help command. Keep the dependency-free CSV helper onpython3.Why
Bare
python3does not provision the script's PEP 723pyyamldependency, so setup can fail on otherwise valid uv-managed installations.Fixes #259
Related #287
How
merge-config.pyinvocations touv runTesting
uv run .../merge-config.py --helpcommanduv run pytest -q tests/test_setup_cleanup_scripts.py(11 passed)uv run pytest -q(2938 passed, 29 skipped)trunk checkgit diff --checkSummary by CodeRabbit
Documentation
Tests