Fix #79 imenu-list update when same position, but different buffer#80
Open
bitterfox wants to merge 1 commit intobmag:masterfrom
Open
Fix #79 imenu-list update when same position, but different buffer#80bitterfox wants to merge 1 commit intobmag:masterfrom
bitterfox wants to merge 1 commit intobmag:masterfrom
Conversation
bitterfox
commented
Apr 4, 2022
| @@ -539,7 +539,7 @@ imenu entries did not change since the last update." | |||
| (unless (and (null force-update) | |||
| imenu-list--last-location | |||
| (marker-buffer imenu-list--last-location) | |||
Author
There was a problem hiding this comment.
I'm not sure the intention here, but if once imenu-list--last-location becomes non buffer location once, imenu-list refuses future updates? (I never experienced such case though)
We maybe should check (marker-buffer location) is nil, instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #79
The cause is comparing the new location and the last location as an integer by
=.https://www.gnu.org/software/emacs/manual/html_node/elisp/Overview-of-Markers.html
so, it's compared with position only, but we should compare with position and buffer so that we update it when the buffer is changed, using equal