Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Benchtop to align with Grip’s new tableId-first storage model by removing assumptions about label-based table resolution.
It ensures that benchmarks reflect the simplified storage architecture and remain accurate after recent Grip changes.
Key Changes
Motivation
Grip recently simplified its storage model by eliminating label indirection. Benchtop needed to be updated to:
This keeps benchmarking aligned with the current architecture.
Impact
Correctness
Maintainability
Notes
This PR does not introduce new benchmark features.
It is primarily a compatibility and alignment update following storage refactors in Grip.