Skip to content

New OS-JR Impl.#16

Open
zeruth wants to merge 5 commits into
bmoyer:masterfrom
zeruth:master
Open

New OS-JR Impl.#16
zeruth wants to merge 5 commits into
bmoyer:masterfrom
zeruth:master

Conversation

@zeruth

@zeruth zeruth commented Dec 20, 2017

Copy link
Copy Markdown

This uses netbeans! lol

So I have done a lot of work on OS-JR. I re-purposed it to be a library.
It has gone from ~300 hooks in the first pull request to 1344. It has every hook Runelite does.

The implementation is explained via comments in "New OS-JR Impl."
Accessed via getters in Hooks.selector after RSGame.run. ex:
int loginstate = Hooks.selector.client.getLoginState();

The full list of Hooks is dumped every update to:
https://github.com/zeruth/OSJR/blob/master/Hooks.txt

And YES! Everything in that list is accessible.

Update hooks to revision 160
Created a new Implementation model with a much much lower footprint. As you can see in RSClient, only about 4 lines of code was needed haha.

This commit uses Netbeans! It conforms as it should have in the first place.

Should be compatible with Devs pull request and others.
This is what a typical OS-JR framework update looks like, simply pulled from https://github.com/zeruth/OSJR/tree/master/export
OSJR has changed a lot, got rid of the single file json object, and un-necessary libraries.
@bmoyer

bmoyer commented Jan 14, 2018

Copy link
Copy Markdown
Owner

Thanks for this. Currently doing some review of this in preparation for merge.

Can you explain a bit in here how the hooks are updated? Also, JSYK the link in your post gives me a 404.

@zeruth

zeruth commented Jan 17, 2018

Copy link
Copy Markdown
Author

For a third party client to OSJR, copy the Hooks.json to your project.

The hooks are populated from rune-lite, whenever a gamepack revision change occurs.

@bmoyer

bmoyer commented Feb 3, 2018

Copy link
Copy Markdown
Owner

Been looking through this more, @zeruth. Would you be able to set things up so that OS-JR is instead compiled from source, rather than adding the jar file itself? I'd be fine just adding a directory to hold the OS-JR source in this repo to compile from.

Mostly looking into this for security reasons. I think the community would be more open to trying a new client if anything like that was compiled by the user (or a trusted third party).

@zeruth

zeruth commented Feb 5, 2018

Copy link
Copy Markdown
Author

The jar is provided really only for convenience. And all it's source code is packed into it.

The intention is for people to fork my repo,
Compile the source.
Export the project as their own jar.

The JAR itself is not necessary to use osjr, but anyone can build the JAR and I recommend they do so.
You could just take my source code and apply it directly, but osjr was designed as a sort of plugin, to separate game accessing from the client, as game accessing is rather fixed.

OSJR is currently in the middle of a big patch at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants