Skip to content

fix: make Mago verification conditional #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnymn merged 1 commit into from
Jul 15, 2026
Merged

fix: make Mago verification conditional #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions plugins/engineering-playbook/skills/development/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,19 @@ use `code-review`. Do not paste the diff or implementation reasoning.

## Verification Gate

Run one Mago round per task after review findings are handled. Do not run Mago
again for fixes or follow-up changes unless the user explicitly asks.
After review findings are handled, run the repository's documented verification
commands. Identify them from project documentation, task or package scripts, CI
workflows, configuration, and declared dependencies.

- Run each command once in order:
- Run Mago only when repository configuration, declared dependencies, or project
documentation confirms that it applies. When it applies, run each command
once in order:
1. `mago fmt --check`
2. `mago lint`
3. `mago analyze`
4. `mago guard`
- Do not run Mago again for fixes or follow-up changes unless the user
explicitly asks.
- Fix Mago warnings and errors without rerunning Mago.
- Stop and ask the user when a Mago fix would change the implementation
direction. Include concrete options.
Expand All @@ -87,8 +92,8 @@ again for fixes or follow-up changes unless the user explicitly asks.
## Pull Request Gate

Create a pull request only after the implementation is done, required review
findings are handled, Mago is clean, and relevant tests pass. Otherwise report
the blocker instead of opening the PR.
findings are handled, applicable verification is clean, and relevant tests pass.
Otherwise report the blocker instead of opening the PR.

When this gate is clean, follow `pull-request` to write the title and
description.