Feature/writer first onboarding#25
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc1bd0a6f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| Subproject commit e791f54723e8a630ae5316dbd6a14e0763924b51 | |||
There was a problem hiding this comment.
This adds .claude/worktrees/project-guidance as a gitlink to commit e791f54, but the commit does not add a matching .gitmodules entry. In a fresh checkout this path is treated as an unconfigured submodule, so commands such as git submodule status fail with “no submodule mapping found,” and the intended Claude guidance files are not available from the repository; remove the accidental gitlink or add a real submodule mapping if this is intentional.
Useful? React with 👍 / 👎.
| pnpm install --frozen-lockfile | ||
| pnpm build | ||
| pnpm test | ||
| pnpm exec playwright install chromium # first time only |
There was a problem hiding this comment.
This checklist is written as a repo-root command sequence, but Playwright is only declared in apps/studio, so pnpm exec playwright ... from the root does not resolve the binary (I checked pnpm exec playwright --version, which fails with Command "playwright" not found). First-time launch testers will fail before pnpm test:e2e; use the same workspace context as CI, e.g. pnpm --filter studio exec playwright install chromium or run it from apps/studio.
Useful? React with 👍 / 👎.
|
Superseded by #27. PR #27 contains an evolved superset of every file here (newer demo-exit DemoBanner, the variant-based WriterWelcomeCard with all five onboarding paths, the mobile post-sidebar toggle, expanded tests, plus editor and security fixes). No unique change in this PR is missing from #27. Closing. |
1 participant
No description provided.