Skip to content

fix: clear pre-existing Studio editor lint errors #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnz183 wants to merge 1 commit into from
Closed

fix: clear pre-existing Studio editor lint errors #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/studio/src/editor/EditorToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ export function EditorToolbar({
}

function insertFileLink(currentEditor: Editor) {
let path = "";
let filename = "Document";
let path: string;
let filename: string;

if (latestUpload?.kind === "pdf") {
path = latestUpload.publicPath;
Expand Down
5 changes: 5 additions & 0 deletions apps/studio/src/editor/SourceDraftEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ export function SourceDraftEditor({
const bodyVersion = useRef(body);
const slashHandlerRef = useRef<(command: SlashCommandId) => void>(() => {});

// Build the slash extension once and dispatch to the latest handler through
// slashHandlerRef, so the Tiptap extension is not rebuilt on every render.
// The React Compiler flags this intentional latest-ref pattern.
/* eslint-disable react-hooks/preserve-manual-memoization, react-hooks/refs */
const slashExtension = useMemo(
() =>
createSlashCommandsExtension(
Expand Down Expand Up @@ -109,6 +113,7 @@ export function SourceDraftEditor({
),
[],
);
/* eslint-enable react-hooks/preserve-manual-memoization, react-hooks/refs */

const editor = useEditor({
extensions: [
Expand Down
Loading