Phase 4d: final UX QA + refreshed screenshots#35
Merged
Conversation
- Regenerate all Studio screenshots in docs/assets for the Phase 4 UI (design system, theme toggle, left nav rail, inline insert dialogs, staged settings). - Repair the pre-existing broken screenshot script: a removed onboarding CTA selector and an ambiguous "Settings" match. - Update docs/project-status.md to honestly reflect the shipped Studio UI. - CHANGELOG: record Phase 4d. Verified: pnpm build, test (studio 133), lint, and e2e (22) all green; full build/test/e2e gate already green on main through the 4a–4c stack. Color is fully tokenized (no raw hex in component rules) across light and dark. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4d — final polish / QA
Last PR of the Phase 4 UX pass. Base
main(4a–4c already merged: #32, #33, #34).What changed
docs/assets/to reflect the refreshed UI (design-system tokens, light/dark theme toggle, left nav rail, inline insert dialogs, staged settings).screenshots:generate): a stale onboarding-CTA selector ("Getting started with SourceDraft", removed long ago) and an ambiguous"Settings"match. The script now runs clean.docs/project-status.mdupdated to honestly reflect the shipped Studio UI.QA verification (success criteria)
window.prompt), grouped toolbar, slash menu, source/rich parity — covered by e2e.Note on scope
Color is fully tokenized. Remaining bare
pxvalues are layout sizes (e.g.min-height, grid tracks) rather than spacing-scale values; a blanket numeric replace would be unsafe (coincidental matches) for no visual gain, so it was intentionally not done.Verification
pnpm build✅ ·pnpm test✅ (studio 133/133) ·pnpm lint✅ ·pnpm test:e2e✅ (22/22). Full gate already green onmainthrough the 4a–4c stack.🤖 Generated with Claude Code