Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo mode, fixtures, Playwright CI, and release screenshots #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Demo mode, fixtures, Playwright CI, and release screenshots #6
Changes from all commits
fa497a9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The web server readiness check only waits for Vite on port 5173, but the configured
devscript starts Vite and the Express API concurrently. If Vite serves the app beforetsx watch server/index.tsis listening on 8787, the initial/api/auth/statuscall is proxied to a closed port,fetchAuthStatusfalls back todemoModeAvailable: false, and the smoke tests cannot find the “Explore demo mode” button. Add an API readiness wait (for example/api/auth/status) before tests interact with the page, or make the webServer command block until both processes are reachable.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.