fix: allow deriving both TryFromJs and TryIntoJs with custom converters#5403
fix: allow deriving both TryFromJs and TryIntoJs with custom converters#5403mansiverma897993 wants to merge 2 commits into
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5403 +/- ##
===========================================
+ Coverage 47.24% 60.23% +12.98%
===========================================
Files 476 567 +91
Lines 46892 63160 +16268
===========================================
+ Hits 22154 38042 +15888
- Misses 24738 25118 +380 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jedel1043
left a comment
There was a problem hiding this comment.
Seems like the best thing we can do right now. We might want to change syntax a bit to be something like boa_try_from_js(with = "function") to avoid code duplication, but that's just a future enhancement IMO. Thanks!
|
@jedel1043 |
Closes #5361