Skip to content

expose fractionalSecondDigits as a property of resolvedOptions()#5414

Open
camilojd wants to merge 1 commit into
boa-dev:mainfrom
camilojd:feat/expose-fractionalSecondDigits-in-resolvedOptions
Open

expose fractionalSecondDigits as a property of resolvedOptions()#5414
camilojd wants to merge 1 commit into
boa-dev:mainfrom
camilojd:feat/expose-fractionalSecondDigits-in-resolvedOptions

Conversation

@camilojd

Copy link
Copy Markdown

Hi boa-devs!

I have a small contribution for the "ECMA-402" effort. Please let me know if this looks good to you.
It changes the following:

  • Exposes fractionalSecondDigits as a property inside the object returned by resolvedOptions()

@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Jun 26, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jun 26, 2026
@github-actions github-actions Bot added C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation labels Jun 26, 2026

@jedel1043 jedel1043 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though you might need to run clippy on this, but preemptively approving.

@github-actions

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,072 51,073 +1
Ignored 1,482 1,482 0
Failed 571 570 -1
Panics 0 0 0
Conformance 96.14% 96.14% +0.00%
Fixed tests (1):
test/intl402/DateTimeFormat/constructor-options-fractionalSecondDigits-valid.js (previously Failed)

Tested main commit: 47eb20a239de0963aec4a6d619c30de48931ccc1
Tested PR commit: d158c9a89af98ebcfc6e2becaeb5fb25d5178fa7
Compare commits: 47eb20a...d158c9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants