Add Linear Regression to Aggregator#262
Conversation
|
Do we have new test cases? |
hridesh
changed the title
| // for ML | ||
| public static String HADOOP_SEQ_FILE_LOCATION = ""; | ||
| public static String HADOOP_OUT_LOCATION = ""; | ||
| //public static String HADOOP_OUT_LOCATION = "/home/tess/Desktop/datagen"; |
There was a problem hiding this comment.
Currently, it is used to store the trained model.
There was a problem hiding this comment.
Perhaps the commented out code on line 80 can be removed.
There was a problem hiding this comment.
Yes, I have removed this line.
src/java/boa/BoaTup.java
Outdated
| @@ -0,0 +1,11 @@ | |||
| package boa; | |||
There was a problem hiding this comment.
What is the relation between BoaTup and BoaTuple, a class that already exists?
There was a problem hiding this comment.
BoaTup is used to read the training data.
There was a problem hiding this comment.
Please see src/java/boa/types/BoaTuple.java. Can that existing type serve this purpose?
There was a problem hiding this comment.
I'm not even sure this is being used.
There are no classes inheriting from this interface. There are no instances of this type being created anywhere.
I think this file, and other code referencing it (like the functions that accept a BoaTup as argument), can probably be removed?
There was a problem hiding this comment.
Currently, I am still using BoaTup for the training data. I have added the function which uses BoaTup. This function will be used to classify the data from trained model.
|
adding/removing line breaks
4 participants
No description provided.