OPTIONS requests and not implemented methods.#2
Open
dim0xff wants to merge 3 commits into
Open
Conversation
3 REST action method Catalyst::Action::REST::_return_not_implemented 4 should return a valid URI for method instead of private method 5 path.
REST action method Catalyst::Action::REST::_return_not_implemented should return a valid URI for method instead of private method path.
Fix: OPTIONS request should return only methods in uppercase, e.g.: method_GET - yes method_POST - yes method_post - no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've made some changes.
_return_not_implemented
Catalyst::Action::REST::_return_not_implemented was returning message with real subroutine name, so everyone can see it. I think it should be visible only for developers, but not for end users. End users should see requested URI.
OPTIONS request method
OPTIONS request method should return in Allow header only subroutines, which have "method part" in uppercase.
A little example for explanation:
So response for OPTIONS request should return the next Allow header:
PS: sorry for my English :-)