Skip to content

OPTIONS requests and not implemented methods.#2

Open
dim0xff wants to merge 3 commits into
bobtfish:masterfrom
dim0xff:master
Open

OPTIONS requests and not implemented methods.#2
dim0xff wants to merge 3 commits into
bobtfish:masterfrom
dim0xff:master

Conversation

@dim0xff

@dim0xff dim0xff commented Mar 9, 2012

Copy link
Copy Markdown

Hello!

I've made some changes.

_return_not_implemented

Catalyst::Action::REST::_return_not_implemented was returning message with real subroutine name, so everyone can see it. I think it should be visible only for developers, but not for end users. End users should see requested URI.

OPTIONS request method

OPTIONS request method should return in Allow header only subroutines, which have "method part" in uppercase.
A little example for explanation:

sub test_sub : Local : ActionClass('REST') { ... }
sub test_sub_GET : Private { ... }
sub test_sub_MY_GET : Private { ... }
sub test_sub_post : Private { ... }

So response for OPTIONS request should return the next Allow header:

Allow: GET MY_GET

PS: sorry for my English :-)

dim0xff added 3 commits March 9, 2012 14:38
3 REST action method Catalyst::Action::REST::_return_not_implemented
4 should return a valid URI for method instead of private method
5 path.
REST action method Catalyst::Action::REST::_return_not_implemented
should return a valid URI for method instead of private method
path.
Fix: OPTIONS request should return only methods in uppercase, e.g.:
method_GET  - yes
method_POST - yes
method_post - no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant