You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not able to build the wheel anymore on this branch. Is it still python setup.py sdist or do we need to update the instructions?
$ python setup.py sdist
Traceback (most recent call last):
File "/home/bodo/Code/python-iconv/setup.py", line 1, in
from setuptools import setup, Extension
ModuleNotFoundError: No module named 'setuptools'
From your log it seems you are running without the setuptools package, with it installed I can run python setup.py sdist on my system with no issues on this branch.
Seems like since python 3.12 setuptools is not installed automatically anymore. I have updated the README.
Tested uploading the package to TestPyPI and it looks good 🎉
Ah good to know. Also it seems the current license field syntax is not yet supported with python 3.8. I'll remove the version from the tests. 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14