Make normalize_whitespace faster#31
Open
pictuga wants to merge 3 commits intobookieio:masterfrom
pictuga:patch-1
Open
Make normalize_whitespace faster#31pictuga wants to merge 3 commits intobookieio:masterfrom pictuga:patch-1
pictuga wants to merge 3 commits intobookieio:masterfrom
pictuga:patch-1
Conversation
A mostly-similar result can be achieved much faster. The only difference is that it doesn't care whether there's a line break in the string.
normalize_whitespace does the job as well
Member
|
I think you should look at user time. And your solution doesn't preserve new lines which may be significant for someone (e.g. for me :). It's great to have code fast but it should work in the first place :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had significant consequences on a program of mine.
Before:
After:
(That's more than a second difference!)
(breadability is called on ± 30 pages during my script execution)
This drops the distinction between \n and whitespaces, but from what I've understood, this distinction is actually not used in the code after.