Use getBoundingClientRect for filler dimensions#123
Open
w00fz wants to merge 1 commit intobooncon:masterfrom
Open
Use getBoundingClientRect for filler dimensions#123w00fz wants to merge 1 commit intobooncon:masterfrom
w00fz wants to merge 1 commit intobooncon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues trying to get the plugin to work with some basic and simple HTML (no images). The ratio for the filler proportions were miscalculated because the target elements had some padding and margin.
I was able to sort this by replacing all the
.width()and.height()calls fromgetFillerProportionsto the more reliable getBoundingClientRect.This worked pretty well for me and if you want to merge the PR, here you have it 😀