refactor: Replace gil::detail::copy_n with std::copy_n#686
refactor: Replace gil::detail::copy_n with std::copy_n#686marco-langer wants to merge 2 commits intoboostorg:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #686 +/- ##
===========================================
- Coverage 80.32% 80.27% -0.06%
===========================================
Files 117 117
Lines 5032 5019 -13
===========================================
- Hits 4042 4029 -13
Misses 990 990 🚀 New features to boost your workflow:
|
| diff_t l=dst.width()-dst.x_pos(); | ||
| diff_t numToCopy=(n<l ? n : l); | ||
| detail::copy_n(src.x(), numToCopy, dst.x()); | ||
| std::copy_n(src.x(), numToCopy, dst.x()); |
There was a problem hiding this comment.
Added line #L244 was not covered by tests
Hmm, this one is interesting. I'd have expected those to be fully covered.
There was a problem hiding this comment.
I don't see any test cases for core\algorithm\copy_pixels. The other specializations of struct copier_n are apparently triggered by some unrelated test cases from extension or image processing tests AFAIS.
Edit: this is not true, there are some legacy tests, which do not cover this case. However, the Jamfile in test\legacy says these tests should not be refactored or extended. Thus, should we rather add new copy_pixels tests in core\algorithm\copy_pixels.cpp?
mloskot
added
cat/refactoring
2 participants
Description
This PR replaces Gil's
gil::detail::copy_nwithstd::copy_n.Tasklist