Skip to content

Use BOOST_INLINE_CONSTEXPR for inline const variables#21

Merged
pdimov merged 2 commits into
boostorg:developfrom
matbech:develop
Feb 5, 2026
Merged

Use BOOST_INLINE_CONSTEXPR for inline const variables#21
pdimov merged 2 commits into
boostorg:developfrom
matbech:develop

Conversation

@matbech
Copy link
Copy Markdown
Contributor

@matbech matbech commented Sep 4, 2021

This fixes the data duplication in translation units when compiling with C++17 or newer.
Fixes issue #20

This fixes the data duplication in translation units when compiling with C++17 or newer
@pdimov pdimov closed this Feb 5, 2026
@pdimov pdimov reopened this Feb 5, 2026
@pdimov pdimov merged commit 0900292 into boostorg:develop Feb 5, 2026
47 checks passed
@georgthegreat
Copy link
Copy Markdown

@pdimov it looks like this PR broke boost/graph:

$S/graph/src/read_graphviz_new.cpp failed with exit code 1 in /home/thegeorg/.ya/build/build_root/nj9s/000004
In file included from $Sgraph/src/read_graphviz_new.cpp:49:
In file included from $Sgraph/include/boost/graph/graphviz.hpp:36:
In file included from $Sxpressive/include/boost/xpressive/xpressive_static.hpp:24:
$Sxpressive/include/boost/xpressive/regex_primitives.hpp:243:71: error: constexpr variable 'epsilon' must be initialized by a constant expression
  243 | BOOST_INLINE_CONSTEXPR proto::terminal<detail::epsilon_matcher>::type epsilon = {{}};
      |                                                                       ^         ~~~~
$Sxpressive/include/boost/xpressive/regex_primitives.hpp:243:81: note: non-constexpr constructor 'expr' cannot be used in a constant expression
  243 | BOOST_INLINE_CONSTEXPR proto::terminal<detail::epsilon_matcher>::type epsilon = {{}};

@pdimov
Copy link
Copy Markdown
Member

pdimov commented Apr 30, 2026

Broke Graph under what compiler with what options? Where does this build log come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants