Composefs changes #1915

Johan-Liebert1 · 2026-01-15T12:56:18Z

Most of this is in prep for #1913

Add option to reset soft reboot state
Don't soft-reboot automatically
Aligning with ostree API, now we only initiate soft-reboot if --apply
is passed to bootc update, bootc switch, else we only prepare the
soft reboot
Update image digest query format
After bootc/commit/49d753f996747a9b1f531abf35ba4e207cf4f020,
composefs-rs saves config in the format oci-config-sha256:.
Update to match the same
composefs/update: Handle --download-only flag
When --download-only is passed, only download the image into the
composefs repository but don't finalize it.
Conver the /run/composefs/staged-deployment to a JSON file and Add a
finalization_locked field depending upon which the finalize service will
either finalize the staged deployment or leave it as is for garbage
collection (even though GC is not fully implemented right now).

Some commits are split from #1913

gemini-code-assist

Code Review

This pull request introduces several enhancements to composefs functionality. It adds an option to reset the soft reboot state and modifies the soft reboot logic to align with the ostree API, where a soft reboot is only initiated if --apply is passed. Additionally, it updates the image digest query format to match recent changes in composefs-rs. The changes are well-structured and improve the consistency and usability of the soft reboot feature. My review includes a suggestion to refactor a part of the new reset_soft_reboot function to improve code clarity and maintainability.

crates/lib/src/bootc_composefs/soft_reboot.rs

Johan-Liebert1 · 2026-01-19T10:51:47Z

Setting up boot components seem to be failing in centos9, f42 with

Bootloader: grub
Installing bootloader via bootupd
error: boot data installation failed: installing component EFI: No such file or directory (os error 2)
error: Installing to disk: Installing bootloader: Failed to run command: Command {
    program: "bootupctl",
    args: [
        "bootupctl",
        "backend",
        "install",
        "--write-uuid",
        "--src-root",
        "/run/bootc/mounts/rootfs/ostree/deploy/default/deploy/3c393b017a7d9c64b3cab4c74372e0226024e26c15983479c3e70455ba0ac62a.0",
        "--device",
        "/dev/loop1",
        "/run/bootc/mounts/rootfs",
    ],
    create_pidfd: false,
}

Johan-Liebert1 · 2026-01-19T11:04:54Z

I guess #1926 is related

cgwalters · 2026-01-20T16:35:48Z

crates/lib/src/bootc_composefs/soft_reboot.rs

 const NEXTROOT: &str = "/run/nextroot";

+#[context("Resetting soft reboot state")]
+fn reset_soft_reboot() -> Result<()> {


I think functions like this should accept their global state, like Storage.

Feels a bit weird to have an argument when they don't use it. We could use run from the Storage, but we need to bind mount /run from host any to unmount nextroot, unless I'm missing something here

cgwalters · 2026-01-20T16:36:26Z

crates/lib/src/bootc_composefs/soft_reboot.rs

+
+    let Some(nextroot) = nextroot else {
+        tracing::debug!("Nextroot is not a directory");
+        println!("No deployment staged for soft rebooting");


Ideally we share these output messages between the two backends

That would be great, but afaik the implementation for soft reboot for ostree backend is in the ostree repo and not bootc. In the ostree path, we don't print anything if there is no deployment staged for soft rebooting. I have updated the final messages, i.e. soft reboot prep complete and soft reboot state reset messages, to match the ostree ones

cgwalters · 2026-01-20T16:37:39Z

crates/lib/src/bootc_composefs/update.rs


    if opts.soft_reboot.is_some() {
-        prepare_soft_reboot_composefs(storage, booted_cfs, &id.to_hex(), true).await?;
+        prepare_soft_reboot_composefs(storage, booted_cfs, Some(&id.to_hex()), true, false).await?;


Having more than one boolean value to functions I think leads to confusion as to what they mean. I think this can become an enum since they're mutually exclusive no?

I think this is from an older commit? I had changed this to an enum

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

Aligning with ostree API, now we only initiate soft-reboot if `--apply` is passed to `bootc update`, `bootc switch`, else we only prepare the soft reboot Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

After bootc/commit/49d753f996747a9b1f531abf35ba4e207cf4f020, composefs-rs saves config in the format `oci-config-sha256:`. Update to match the same Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

When `--download-only` is passed, only download the image into the composefs repository but don't finalize it. Conver the /run/composefs/staged-deployment to a JSON file and Add a finalization_locked field depending upon which the finalize service will either finalize the staged deployment or leave it as is for garbage collection (even though GC is not fully implemented right now). Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

cgwalters · 2026-01-21T16:48:12Z

crates/lib/src/bootc_composefs/export.rs

+    // We want the digest in the form of "sha256:abc123"
+    let config_digest = format!("{}", imginfo.manifest.config().digest());


Hmm isn't this us losing type safety in that basically composefs-rs is using a different type alias for digests than exists in https://docs.rs/oci-spec/latest/oci_spec/image/struct.Digest.html ?

I think we could probably impl From<oci_spec::Digest> for composefs_rs::Sha256Digest or so?

Having to go through strings is definitely a big trap.

cgwalters · 2026-01-21T16:49:06Z

crates/lib/src/bootc_composefs/soft_reboot.rs

+#[context("Resetting soft reboot state")]
+pub(crate) fn reset_soft_reboot() -> Result<()> {
+    let run = Utf8Path::new("/run");
+    bind_mount_from_pidns(PID1, &run, &run, true).context("Bind mounting /run")?;


I don't think this is necessary, we only need to do that when run under podman.

cgwalters · 2026-01-21T16:49:44Z

crates/lib/src/bootc_composefs/soft_reboot.rs

+        .context("Opening nextroot")?;
+
+    let Some(nextroot) = nextroot else {
+        tracing::debug!("Nextroot is not a directory");


It doesn't exist, not just not a directory

cgwalters · 2026-01-21T16:53:03Z

crates/lib/src/bootc_composefs/soft_reboot.rs

+        return Ok(());
+    }
+
+    unmount(NEXTROOT, UnmountFlags::DETACH).context("Unmounting nextroot")?;


Does this work though? We always enter a mount namespace, so this is where...ohhhh, I see that's why you did the bind mount of /run from the host mountns above.

And indeed I think we have similar code in ostree.

But...hmmm I think it'd be cleaner to avoid mutating global state this way - we could fork a child process that does the umount (look at similar code in bind_mount_from_pidns) or we could always pull in the real /run right after we do the re-exec to enter a new mountns.

cgwalters · 2026-01-21T16:53:14Z

crates/lib/src/bootc_composefs/soft_reboot.rs

    storage: &Storage,
    booted_cfs: &BootedComposefs,
-    deployment_id: &String,
+    deployment_id: Option<&String>,


Prefer Option<&str>

cgwalters · 2026-01-21T16:53:49Z

crates/lib/src/bootc_composefs/status.rs

 }

+#[derive(Debug, Serialize, Deserialize)]
+pub(crate) struct StagedDeployment {


This one seems like it could use a comment

cgwalters · 2026-01-21T16:55:20Z

crates/lib/src/bootc_composefs/update.rs

+            .atomic_replace_with(
+                COMPOSEFS_STAGED_DEPLOYMENT_FNAME,
+                |f| -> std::io::Result<()> {
+                    f.write_all(new_staged.to_canon_json_string()?.as_bytes())


Doesn't matter here but we can optimize this by not serializing to an intermediate string by using the canon-json-rs formatter with serde_json::to_writer

Johan-Liebert1 requested a review from cgwalters January 15, 2026 12:56

gemini-code-assist bot reviewed Jan 15, 2026

View reviewed changes

crates/lib/src/bootc_composefs/soft_reboot.rs Show resolved Hide resolved

Johan-Liebert1 force-pushed the cfs-changes branch 2 times, most recently from 0193cf9 to 364e600 Compare January 19, 2026 09:25

cgwalters requested changes Jan 20, 2026

View reviewed changes

Johan-Liebert1 force-pushed the cfs-changes branch from 364e600 to ad5fa7f Compare January 21, 2026 05:14

Johan-Liebert1 added 4 commits January 21, 2026 08:04

composefs: Add option to reset soft reboot state

8c04825

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

composefs: Don't soft-reboot automatically

cc61ac5

Aligning with ostree API, now we only initiate soft-reboot if `--apply` is passed to `bootc update`, `bootc switch`, else we only prepare the soft reboot Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

composefs/export: Update image digest query format

24c7c16

After bootc/commit/49d753f996747a9b1f531abf35ba4e207cf4f020, composefs-rs saves config in the format `oci-config-sha256:`. Update to match the same Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>

cgwalters force-pushed the cfs-changes branch from ad5fa7f to 3793354 Compare January 21, 2026 13:08

cgwalters self-assigned this Jan 21, 2026

jeckersb self-assigned this Jan 21, 2026

cgwalters reviewed Jan 21, 2026

View reviewed changes

		// We want the digest in the form of "sha256:abc123"
		let config_digest = format!("{}", imginfo.manifest.config().digest());

Composefs changes #1915

Are you sure you want to change the base?

Composefs changes #1915

Conversation

Johan-Liebert1 commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Johan-Liebert1 commented Jan 19, 2026

Uh oh!

Johan-Liebert1 commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Johan-Liebert1 Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Johan-Liebert1 commented Jan 15, 2026 •

edited

Loading

Johan-Liebert1 Jan 21, 2026 •

edited

Loading