test: Add test required packages in Packit provision #1937
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install-to-filesystem-var-mount test requires packages which should be built into image for Packit provision (system-reinstall-bootc on package mode testing farm runner) Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly adds the necessary packages (parted, lvm2, dosfstools, e2fsprogs) to hack/packages.txt as required by the install-to-filesystem-var-mount test. The change is clear, well-documented with a comment, and directly addresses the stated need in the pull request description. No further issues or improvements of medium or higher severity were identified.
Collaborator
Author
|
Yes, all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-to-filesystem-var-mounttest requires packages which should be built into image for Packit provision (system-reinstall-bootc on package mode testing farm runner)