Skip to content

Promote implemented design docs#1021

Closed
bootjp wants to merge 1 commit into
mainfrom
design/promote-implemented-design-docs
Closed

Promote implemented design docs#1021
bootjp wants to merge 1 commit into
mainfrom
design/promote-implemented-design-docs

Conversation

@bootjp

@bootjp bootjp commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • promote implemented design documents from proposed or partial status to implemented filenames/status
  • update code comments and design cross-links so they point at the implemented docs
  • keep still-open roadmap and follow-up docs proposed while refreshing their references to shipped dependencies

Design docs

  • docs/design/2026_04_20_implemented_lease_read.md
  • docs/design/2026_04_26_implemented_sqs_per_queue_throttling.md
  • docs/design/2026_04_27_implemented_keyviz_cluster_fanout.md
  • docs/design/2026_04_27_implemented_keyviz_spa_integration.md
  • docs/design/2026_04_28_implemented_admin_delete_bucket_safety_net.md
  • docs/design/2026_04_28_implemented_keyviz_adapter_labels.md
  • docs/design/2026_05_25_implemented_keyviz_subrange_sampling.md
  • docs/design/2026_05_25_implemented_snapshot_logical_encoder.md
  • docs/design/2026_05_28_implemented_keyviz_hot_key_topk.md
  • docs/design/2026_05_30_implemented_sqs_side_record_derivation.md
  • docs/design/2026_06_01_implemented_snapshot_encode_cli.md
  • docs/design/2026_06_03_implemented_s3_collision_reversal.md
  • docs/design/2026_06_03_implemented_sqs_partitioned_fifo_encoder.md
  • docs/design/2026_06_10_implemented_redis_onephase_dedup_default_on.md
  • docs/design/2026_06_16_implemented_sqs_dlq_redrive_admin_ui.md

Validation

  • git diff --check origin/main..HEAD
  • git verify-commit HEAD
  • searched for the renamed proposed/partial design-doc filenames and found no remaining references

Author: bootjp

@bootjp

bootjp commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a574a243-3812-48c6-8ca8-a12547ff6022

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch design/promote-implemented-design-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: d570cd6529

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates references to design documents from 'proposed' to 'implemented' across various code comments, documentation, and configuration files, reflecting that these features have now been fully shipped or implemented. It also updates the status of several design documents themselves to 'Implemented'. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@bootjp

bootjp commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

Closing this batch draft as superseded by the per-design-doc PRs. It also includes the KeyViz adapter-labels promotion that was explicitly closed in #1028 because adapter-label support is not present on main yet. Keeping this batch open would duplicate the individual doc PRs and risk marking an unimplemented design as implemented.

@bootjp bootjp closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant