You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As suggested in #149 this removes setup.py/setup.cfg and replaces it with hatch, configured in the pyproject.toml. I took inspiration from the hatch projects' pypoetry.toml for this.
The metadata was directly converted with some more keywords and classifiers added. The version number moved to __about__.py. I also added a custom build hook to compile the resources.qrc as was done in the setup.py. It's my first time writing a hatch hook, so if you spot something feel free to point it out.
I already added black, pytest, ... as environment/development dependencies as well as some basic configuration. The windows-binary.yml workflow still works as well.
Basic usage of hatch looks like this (with hatch installed e.g. through pip install hatch or package manager):
# Run program/script (also sets up virtual environment and builds artifacts)
hatch run rmview
# Setup environment in `.venv` folder
hatch env create
# Build distribution
hatch build
# Activate python environment
hatch shell
I'd appreciate it if you could have a look. To keep things simple I thought I'd start off by only switching to hatch at first and then doing the other things from #149 I proposed.
I don't have much experience contributing to projects on Github, so If I should e.g. just put all the changes in consecutive commits on this request or so - please, feel free to instruct me 😅
I have tried to use hatch but something is not working.
I don't understand how this works so I might just be doing something stupid.
I installed hatch, then run hatch run rmview which started building the environment and complained about a bunch of dependencies. I (re?)installed the dependencies manually and those errors were replaced by a runtime exception triggered by twisted in relation to OpenSSL. Needless to say, rmview works if run on the vnc branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #149 this removes
setup.py/setup.cfgand replaces it with hatch, configured in thepyproject.toml. I took inspiration from the hatch projects'pypoetry.tomlfor this.The metadata was directly converted with some more keywords and classifiers added. The version number moved to
__about__.py. I also added a custom build hook to compile theresources.qrcas was done in thesetup.py. It's my first time writing a hatch hook, so if you spot something feel free to point it out.I already added black, pytest, ... as environment/development dependencies as well as some basic configuration. The
windows-binary.ymlworkflow still works as well.Basic usage of hatch looks like this (with
hatchinstalled e.g. throughpip install hatchor package manager):