legacy: lazy-import legacy classes inside v1 branches only, refs #9556#9650
Open
mr-raj12 wants to merge 1 commit into
Open
legacy: lazy-import legacy classes inside v1 branches only, refs #9556#9650mr-raj12 wants to merge 1 commit into
mr-raj12 wants to merge 1 commit into
Conversation
031a902 to
9fa3b5f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9650 +/- ##
==========================================
- Coverage 83.08% 83.05% -0.04%
==========================================
Files 90 90
Lines 15653 15659 +6
Branches 2356 2359 +3
==========================================
- Hits 13006 13005 -1
- Misses 1887 1891 +4
- Partials 760 763 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes top-level
LegacyRepository,LegacyRemoteRepository, andRepoObj1imports from three files, moving each to the branch that uses it, refs #9556.borg.remote:LegacyRepositoryimported insideRepositoryServer.open(), guarded byv1_or_v2borg.archiver._common:LegacyRemoteRepositoryandLegacyRepositoryimported insideget_repository()under the same guard;RepoObj1imported insidewith_other_repository()underrepository.version == 1borg.archiver.transfer_cmd:LegacyRepositoryimported at the top oftransfer_chunks(), where it appears in theexcepttupleNo logic changes. None of these modules pull in
borg.legacyat import time anymore, so a future phase can drop the package without them breaking at startup.Refs #9556
Checklist