Skip to content

test(memory): add comprehensive SAGA abort tests for CortexMemoryManager#445

Open
borjamoskv wants to merge 1 commit into
mainfrom
memory-manager-saga-tests-1531063238408088870
Open

test(memory): add comprehensive SAGA abort tests for CortexMemoryManager#445
borjamoskv wants to merge 1 commit into
mainfrom
memory-manager-saga-tests-1531063238408088870

Conversation

@borjamoskv

Copy link
Copy Markdown
Owner

This PR adds robust unit and integration tests to ensure that failure modes and rollbacks in the CortexMemoryManager pipeline are handled correctly.

Modifications:

  • Consolidated memory tests into the tests/memory/ directory to follow the project's internal constraints for package-to-test mapping.
  • Implemented simulated SAGA abort tests (rollback/compensation) in tests/memory/test_manager_v2.py covering all the missing stages of the CortexMemoryManager.store pipeline: Exergy Pre-Filter, Thalamus Gate, Deduplication, and Vector Encoding. This supplements the existing Resonance Gate abort test.
  • Tested locally to ensure the new coverage functions correctly.

PR created automatically by Jules for task 1531063238408088870 started by @borjamoskv

- Moved `tests/test_reconsolidation_comprehensive.py` to `tests/memory/test_reconsolidation.py`.
- Moved `tests/test_memory_manager_lifecycle.py` to `tests/memory/test_manager_v2.py`.
- Added missing SAGA abort tests in `tests/memory/test_manager_v2.py` for Exergy Pre-Filter, Thalamus Gate, Deduplication, and Vector Encoding stages of the `store` pipeline.

Co-authored-by: borjamoskv <82632764+borjamoskv@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the tests label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

∞ MÖBIUS — PR Analysis

Metric Value
Files changed 2
Total changes 47 (+/-)
Complexity low
Est. review time 5 min
Has tests?
Has Rust changes? No

Labels applied: tests


Generated by MÖBIUS (Clojure/Babashka) — where code IS data

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant