Add maven wrapper and clarigy frontend status in readme#35
Add maven wrapper and clarigy frontend status in readme#35buayism wants to merge 1 commit intobos-com:mainfrom
Conversation
Fix bos-com#26 - add mvn wrapper and clarify frontend status in readme file Fix bos-com#25 - Clarify that greencode-frontend/ is planned butnot yet in repository
|
@buayism is attempting to deploy a commit to the mukisalivingstone133-9917's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
gonna take a look into this PR will give in feedback soon |
RonaldRonnie
left a comment
RonaldRonnie
left a comment
There was a problem hiding this comment.
Great work adding the Maven Wrapper @buayism . This is exactly what we needed 👍
I can see mvnw, mvnw.cmd, and the wrapper properties file are included. Could you please confirm that .mvn/wrapper/maven-wrapper.jar is also committed (it may not appear in the diff)?
Also, I noticed a small unrelated change in the README regarding the frontend folder. could you clarify if this is intentional? It might be better to keep this PR focused only on the Maven Wrapper? because this part of the frontend is supposed to be in the esm-greencode repo.
Once confirmed, this should be good to merge 🚀
2 participants
Fix #26 - add mvn wrapper and clarify frontend status in readme file Fix #25 - Clarify that greencode-frontend/ is planned butnot yet in repository