fix: improve promote-release workflow robustness and error handling#146
Merged
boscorat merged 1 commit intoJul 8, 2026
Merged
Conversation
Address git-expert review feedback with the following improvements: - Fix draft release check logic: now explicitly rejects already-live releases instead of warning and proceeding (prevents accidental re-promotion) - Add artifact validation: verify wheel and sdist exist before publishing to PyPI - Implement PyPI verification with exponential backoff retry (up to 5 attempts) at 10s, 25s, 40s, 55s, 70s intervals to handle slower indexing - Fix string interpolation: use heredoc to avoid shell-to-Python interpolation issues with special characters in package names - Reorder deployment creation: create deployment AFTER PyPI verification succeeds to ensure deployment records accurately reflect release state - Add conditional guards: deployment status only updates if deployment created - Simplify retroactive docs update: improve error handling, clearer git state management, explicit cleanup of stashed changes - Add better error messages: distinguish between missing releases, non-draft releases, artifact download failures, and verification timeouts All changes maintain backward compatibility while improving reliability and maintainability. Workflow will now handle edge cases and transient failures more gracefully. Signed-off-by: Jason Farrar <farrar.jason1@gmail.com>
d46f265 to
020d630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address git-expert review feedback with the following improvements:
All changes maintain backward compatibility while improving reliability and maintainability. Workflow will now handle edge cases and transient failures more gracefully.