fix: create draft releases and defer cleanup until manual promotion#83
Merged
Merged
Conversation
- Add 'draft: true' to all 4 softprops/action-gh-release upload steps (Linux, Linux ARM64, Windows, macOS) - Draft releases prevent premature publication while allowing time for verification - Modified cleanup job to skip draft releases until manually promoted from draft → published - Cleanup job now checks isDraft flag before stripping old release assets - Draft releases won't be cleaned up until promoted by maintainer This addresses issue #81: Release workflow should create draft releases. Releases must be manually promoted after verification and platform-specific checks (e.g., Windows MSI submission to Microsoft WDSI portal, macOS notarisation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements draft releases for the openstan release workflow, addressing issue #81. Releases are now created as drafts and must be manually promoted after verification and platform-specific checks.
Changes
.github/workflows/release.ymldraft: trueto all 4softprops/action-gh-releaseupload steps:isDraftflag before stripping old release assetsRELEASE.md(new file)Behavior Changes
Before:
After:
gh release edit <tag> --draft=falseTesting
✓ All pre-PR checks pass:
Related
Closes #81
References #76 (original release pipeline review)