feat: add visibility of BSP debug Excel files in Debug Information dialog#87
Merged
boscorat merged 1 commit intoJul 8, 2026
Conversation
closeEvent can be triggered during initialization if database errors occur (e.g., lock timeout). The event handler tried to access stan_presenter which may not have been initialized yet, causing an AttributeError. Add hasattr() guard to safely check if stan_presenter exists before accessing it. This allows the application to close gracefully even if initialization fails.
boscorat
deleted the
80-statement-debugging---add-visibility-of-bsp-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements full support for BSP's new
debug_dataframes.xlsxdebugging files by:Changes
Database Schema
debug_excel_pathcolumn tostatement_resulttabledebug_dataframes.xlsxalongsidedebug_json_pathData Model
debug_excel_path: Path | Nonefield toResultRowdataclassupdate_debug_info()to persist both JSON and Excel pathsPresenter
DebugWorkerto detectdebug_dataframes.xlsxfileentry_done(result_id, debug_json_path, debug_excel_path)UI
BSP Integration
_write_debug_json()now returns the actual file pathdebug_pdf_statement()uses returned path (no duplicate path construction)pdf.stem(in _write_debug_json) andpdf.name(in debug_pdf_statement)Bug Fixes
Testing
User Experience
When debugging failed/review statements:
Files Modified
src/openstan/data/create_gui_db.py— Add schema columnsrc/openstan/models/statement_result_model.py— Add field and update methodssrc/openstan/presenters/statement_result_presenter.py— Detect and emit Excel pathsrc/openstan/views/debug_info_dialog.py— Add Excel column and buttonssrc/openstan/main.py— Guard closeEvent against initialization errorsRelated Issues
Fixes #80 — Statement Debugging - add visibility of BSP improvements
Related PRs
This PR requires bank_statement_parser ≥ 0.3.7 (commit 1df6293 or later) to work correctly.